Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve get_resource() #32

Merged
merged 10 commits into from
Mar 6, 2023

Conversation

n7studios
Copy link
Contributor

@n7studios n7studios commented Mar 3, 2023

Summary

Improves the get_resource() API function, with PHP 8.2 compatibility for fetching legacy forms and legacy landing pages, handling encoding (as used in the WordPress Libraries code)

Removes outdated (and now unused) dependencies and not recommended file_get_contents() calls.

Testing

  • testGetResourceLegacyForm: Tests that fetching a legacy form's HTML works with correct encoding
  • testGetResourceLandingPage: Tests that fetching a landing page's HTML works with correct encoding
  • testGetResourceLegacyLandingPage: Tests that fetching a legacy landing page's HTML works with correct encoding

Checklist

@n7studios n7studios added this to the 1.0.0 milestone Mar 3, 2023
@n7studios n7studios requested review from a team, noelherrick and corydhmiller and removed request for a team March 3, 2023 16:45
@n7studios n7studios marked this pull request as ready for review March 3, 2023 16:45
@n7studios n7studios self-assigned this Mar 3, 2023
@n7studios n7studios merged commit 366a9e7 into fix-get-subscriber-id-performance Mar 6, 2023
@n7studios n7studios deleted the fix-get-resource branch March 23, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants