Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor logging and API calls #38

Merged
merged 3 commits into from
Mar 7, 2023
Merged

Conversation

n7studios
Copy link
Contributor

Summary

  • Moves create_log() calls from each API function to HTTP verb function (get, post, delete, put)
  • Removes unnecessary initialization of variables for some API function calls
  • Refactors get_resources() to improve code readability

Testing

Existing tests pass

Checklist

… where not required; refactor get_resources()
@n7studios n7studios added this to the 1.0.0 milestone Mar 6, 2023
@n7studios n7studios self-assigned this Mar 6, 2023
@n7studios n7studios requested review from a team, noelherrick and corydhmiller and removed request for a team March 6, 2023 16:42
@n7studios n7studios marked this pull request as ready for review March 6, 2023 16:42
@n7studios n7studios changed the base branch from move-api-version-into-make-request to 1.0-beta March 7, 2023 15:00
@n7studios n7studios merged commit 9521ed2 into 1.0-beta Mar 7, 2023
@n7studios n7studios deleted the refactor-logging-and-api-calls branch March 23, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants