Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_forms() and get_landing_pages() API functions #41

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

n7studios
Copy link
Contributor

Summary

Adds get_forms() and get_landing_pages() API functions, as a convenience vs. having to call get_resources('forms') or get_resources('landing_pages').

Removes unnecessary timeout and encoding headers on requests for resources.

When fetching landing pages, exclude forms from the resultset.

Testing

  • testGetForms: Tests that fetching forms works with expected response data.
  • testGetLandingPages: Tests that fetching landing pages works with expected response data.

Checklist

@n7studios n7studios self-assigned this Mar 9, 2023
@n7studios n7studios added this to the 1.0.0 milestone Mar 9, 2023
@n7studios n7studios requested review from a team, noelherrick and corydhmiller and removed request for a team March 9, 2023 15:39
@n7studios n7studios marked this pull request as ready for review March 9, 2023 15:40
# Conflicts:
#	src/ConvertKit_API.php
#	tests/ConvertKitAPITest.php
@n7studios n7studios merged commit 3cc8333 into 1.0-beta Mar 10, 2023
@n7studios n7studios deleted the get-forms-landing-pages branch March 23, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants