Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add set_http_client method #68

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Add set_http_client method #68

merged 1 commit into from
Jul 18, 2023

Conversation

n7studios
Copy link
Contributor

Summary

Allows users to define their own HTTP client compatible with ClientInterface.

Implementation of this PR, with tests now passing.

Testing

  • testClientInterfaceInjection(): Injects a GuzzleHttp\Handler\MockHandler and asserts the results are as expected when mocking an API request.

Checklist

@n7studios n7studios added this to the 1.3.0 milestone Jul 17, 2023
@n7studios n7studios self-assigned this Jul 17, 2023
@n7studios n7studios mentioned this pull request Jul 17, 2023
Closed
5 tasks
@n7studios n7studios requested review from a team, noelherrick and jenessawhite and removed request for a team July 17, 2023 12:53
@n7studios n7studios marked this pull request as ready for review July 17, 2023 12:53
@n7studios n7studios merged commit 415075b into master Jul 18, 2023
@n7studios n7studios deleted the use-guzzle-clientinterface branch September 11, 2023 11:03
@n7studios n7studios mentioned this pull request Mar 21, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noelherrick noelherrick noelherrick approved these changes

@jenessawhite jenessawhite Awaiting requested review from jenessawhite jenessawhite was automatically assigned from Kit/wordpress

Assignees

@n7studios n7studios

Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@n7studios @noelherrick