Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using PHP 7.3 results in warnings #173

Closed
tnorthcutt opened this issue Feb 4, 2019 · 0 comments
Closed

Using PHP 7.3 results in warnings #173

tnorthcutt opened this issue Feb 4, 2019 · 0 comments
Assignees
@tnorthcutt
Labels
bug has PR ship

Comments

@tnorthcutt
Copy link
Contributor

Warning: preg_match_all(): Compilation failed: invalid range in character class at offset 4 in /wp-content/plugins/ConvertKit-WordPress/lib/simple-html-dom/simple-html-dom.php on line 684

This is because the underlying library we're using isn't PHP 7.3 compatible: sunra/php-simple-html-dom-parser#64

Instead, we should move to this updated library: composer require kub-at/php-simple-html-dom-parser (which is really just a copy of the Sourceforge version we have copied in at the moment, but sourcing from Composer will be 👍 )
@tnorthcutt tnorthcutt added the bug label Feb 4, 2019
@tnorthcutt tnorthcutt self-assigned this Feb 4, 2019
tnorthcutt added a commit that referenced this issue Feb 4, 2019
@tnorthcutt
Use updated version of simple-html-dom-parser library
0f1c7e9 
Replaces an old version with one updated for PHP 7.3. This is needed b/c
PHP 7.3 changes how it handles regular expressions; the PCRE extension was
upgraded: https://secure.php.net/manual/en/migration73.other-changes.php#migration73.other-changes.pcre

Closes #173
@tnorthcutt tnorthcutt mentioned this issue Feb 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tnorthcutt tnorthcutt

Labels
bug has PR ship
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tnorthcutt