-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broadcasts to Posts: Import Thumbnail Setting #599
Conversation
sudo chown www-data:www-data ${{ env.ROOT_DIR }}/wp-config.php | ||
sudo chmod g+w ${{ env.ROOT_DIR }}/wp-content | ||
|
||
sudo chmod 767 ${{ env.ROOT_DIR }}/wp-content |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the user need execute on these files? This chmod includes that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the executable permission results in tests not being able to run, and e.g. log files not being writable/modified:
These permissions are expansive, but it seems to be the best way to permit the tests and WordPress access to writing to e.g. the Media Library uploads folder (link)
Summary
Adds an option to enable / disable importing the Broadcast's thumbnail to the WordPress Post's Featured Image, enabled by default.
Previously, a Broadcast's thumbnail would be set as the WordPress Post's Featured Image.
Testing
testBroadcastsImportWithImportThumbnailDisabled
: Test that no thumbnail is set as the Featured Image when theImport Thumbnail
setting is disabled.Checklist