Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcasts to Posts: Import Thumbnail Setting #599

Merged
merged 19 commits into from
Jan 2, 2024

Conversation

n7studios
Copy link
Contributor

@n7studios n7studios commented Dec 27, 2023

Summary

Adds an option to enable / disable importing the Broadcast's thumbnail to the WordPress Post's Featured Image, enabled by default.

Previously, a Broadcast's thumbnail would be set as the WordPress Post's Featured Image.

Screenshot 2023-12-27 at 14 24 37

Testing

  • testBroadcastsImportWithImportThumbnailDisabled: Test that no thumbnail is set as the Featured Image when the Import Thumbnail setting is disabled.
  • Other broadcast tests updated to check thumbnail is set as the Featured Image; GitHub action file permissions updated to allow WordPress to store imported images in the filesystem

Checklist

@n7studios n7studios self-assigned this Dec 27, 2023
@n7studios n7studios requested review from a team, noelherrick and jenessawhite and removed request for a team January 2, 2024 11:51
@n7studios n7studios marked this pull request as ready for review January 2, 2024 11:51
sudo chown www-data:www-data ${{ env.ROOT_DIR }}/wp-config.php
sudo chmod g+w ${{ env.ROOT_DIR }}/wp-content

sudo chmod 767 ${{ env.ROOT_DIR }}/wp-content
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the user need execute on these files? This chmod includes that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the executable permission results in tests not being able to run, and e.g. log files not being writable/modified:
Screenshot 2024-01-02 at 14 45 07

These permissions are expansive, but it seems to be the best way to permit the tests and WordPress access to writing to e.g. the Media Library uploads folder (link)

@n7studios n7studios merged commit b604016 into main Jan 2, 2024
77 checks passed
@n7studios n7studios deleted the broadcasts-to-posts-thumbnail-setting branch February 8, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants