Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth: Support tenant_name Parameter #70

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Conversation

n7studios
Copy link
Contributor

Summary

Adds support for specifying the tenant_name parameter, to issue unique OAuth tokens to multiple instances using the same Kit account and OAuth Client / App ID.

Testing

Manual end to end test completing OAuth flow with the same Kit account and OAuth Client / App ID confirms this working:

Screenshot_2024-11-11_at_09_22_52
Screenshot_2024-11-11_at_09_22_59

Checklist

@n7studios n7studios added the enhancement New feature or request label Nov 11, 2024
@n7studios n7studios self-assigned this Nov 11, 2024
@n7studios n7studios requested review from a team, noelherrick and jenessawhite and removed request for a team November 11, 2024 02:24
@n7studios n7studios marked this pull request as ready for review November 11, 2024 02:25
@n7studios n7studios mentioned this pull request Nov 11, 2024
6 tasks
Copy link

@noelherrick noelherrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with the probably unnecessary reminder to change to prod WP libraries before merging.

@n7studios n7studios merged commit e4e9523 into main Nov 12, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants