Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Signal Handling to be Cross-Platform #71

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

tyleranton
Copy link
Contributor

@tyleranton tyleranton commented Aug 14, 2024

This PR introduces the proposed changes from #58

  • Removed the dependency on signal_hook.
  • Implemented Unix-specific signal handling using tokio::signal::unix.
  • Implemented Windows-specific signal handling using tokio::signal::ctrl_c.

closes #58

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 32.45%. Comparing base (225f81e) to head (3c4cc70).
Report is 1 commits behind head on main.

Files Patch % Lines
src/server/mod.rs 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   32.59%   32.45%   -0.15%     
==========================================
  Files          28       28              
  Lines        2227     2237      +10     
==========================================
  Hits          726      726              
- Misses       1501     1511      +10     
Flag Coverage Δ
unittests 32.45% <0.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jessfraz
Copy link
Contributor

thank you!

@jessfraz jessfraz merged commit 1819539 into KittyCAD:main Aug 14, 2024
5 of 6 checks passed
@tyleranton tyleranton deleted the cross-platform-signals branch August 14, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Signal Handling to be Cross-Platform
2 participants