Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rotations to LinearTransform #455

Merged
merged 24 commits into from
Aug 28, 2024
Merged

Conversation

gserena01
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@cb2a840). Learn more about missing BASE report.

Files with missing lines Patch % Lines
modeling-cmds/src/shared.rs 0.00% 12 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #455   +/-   ##
=======================================
  Coverage        ?   26.21%           
=======================================
  Files           ?       29           
  Lines           ?     1694           
  Branches        ?        0           
=======================================
  Hits            ?      444           
  Misses          ?     1250           
  Partials        ?        0           
Flag Coverage Δ
unittests 26.21% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gserena01 gserena01 marked this pull request as ready for review August 16, 2024 18:04
@gserena01 gserena01 requested a review from adamchalmers August 20, 2024 15:04
Copy link
Collaborator

@adamchalmers adamchalmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid a breaking change by renaming, lets:

  • Mark the current struct as deprecated
  • Create a new struct with the new name and the rotation field
  • migrate the frontend to use the new struct
  • delete the old struct

@gserena01 gserena01 requested a review from adamchalmers August 27, 2024 15:55
@gserena01 gserena01 merged commit 2c541fd into main Aug 28, 2024
8 checks passed
@gserena01 gserena01 deleted the serena/rotations-transform-patterns branch August 28, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants