Mike/lofting enums #461
Mike/lofting enums #461
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #461 +/- ##
=======================================
Coverage ? 26.42%
=======================================
Files ? 29
Lines ? 1680
Branches ? 0
=======================================
Hits ? 444
Misses ? 1236
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
modeling-cmds/src/def_enum.rs
Outdated
| /// The closed section curves to create a lofted solid from. | ||
| /// Currently, these must be Solid2D's | ||
| pub section_ids: Vec<Uuid>, | ||
| /// Degree of the interpolation. Pass 2 for quadratic, and 3 for cubic interpolation in the V direction. |
There was a problem hiding this comment.
Are these the only valid values? If so this should be an enum, like this playground
There was a problem hiding this comment.
No, any value is valid except I suppose 0. So this should be kept as the integer I have
| /// The response from the `Loft` command. | ||
| #[derive(Debug, Serialize, Deserialize, JsonSchema, ModelingCmdOutput)] | ||
| pub struct Loft { | ||
| ///The UUID of the newly created solid loft. |
There was a problem hiding this comment.
This is a solid3d right?
There was a problem hiding this comment.
yes, but the reader should be able to infer that a solid loft is a solid 3d. there's no such thing as a solid lofted 2D in our engine
Co-authored-by: Adam Chalmers <adam.chalmers@zoo.dev>
No description provided.