Remove icon.ico, keep only icon.png, see https://www.electron.build/i…

…cons.html#windows-nsis
KittyCAD · Nov 28, 2024 · b97f81b · b97f81b
1 parent 44adcb2
commit b97f81b
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 5 deletions.
diff --git a/.github/workflows/build-apps.yml b/.github/workflows/build-apps.yml
@@ -65,7 +65,6 @@ jobs:
             electron-builder.yml
             src/wasm-lib/pkg/wasm_lib*
             release-notes.md
-            assets/icon.ico
             assets/icon.png
 
       - id: export_version
@@ -117,7 +116,6 @@ jobs:
           mkdir src/wasm-lib/pkg
           cp prepared-files/src/wasm-lib/pkg/wasm_lib* src/wasm-lib/pkg
           cp prepared-files/release-notes.md release-notes.md
-          cp prepared-files/assets/icon.ico assets/icon.ico
           cp prepared-files/assets/icon.png assets/icon.png
 
       - name: Sync node version and setup cache

diff --git a/assets/icon-nightly.ico b/assets/icon-nightly.ico
diff --git a/assets/icon.ico b/assets/icon.ico
diff --git a/electron-builder.yml b/electron-builder.yml
@@ -40,7 +40,6 @@ win:
     - sha256
   sign: "./sign-win.js"
   publisherName: "KittyCAD Inc" # needs to be exactly like on Digicert
-  icon: "assets/icon.ico"
   fileAssociations:
     - ext: kcl
       name: kcl
@@ -54,7 +53,6 @@ nsis:
   oneClick: false
   perMachine: true
   allowElevation: true
-  installerIcon: "assets/icon.ico"
   include: "./installer.nsh"
 linux:
   artifactName: "${productName}-${version}-${arch}-${os}.${ext}"

diff --git a/scripts/flip-files-to-nightly.sh b/scripts/flip-files-to-nightly.sh
@@ -17,4 +17,3 @@ echo "Nightly build $VERSION (commit $COMMIT)" > release-notes.md
 
 # icons
 cp assets/icon-nightly.png assets/icon.png
-cp assets/icon-nightly.ico assets/icon.ico