Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Electron test: (regression) select all in code editor does not actually select all, just what is visible #3175

Closed
jessfraz opened this issue Jul 29, 2024 · 3 comments · Fixed by #3540
Closed

Electron test: (regression) select all in code editor does not actually select all, just what is visible #3175

jessfraz opened this issue Jul 29, 2024 · 3 comments · Fixed by #3540
Assignees
@Irev-Dev
Labels
bug Something isn't working codemirror Bugs related to code mirror. desktop-app Issues from the desktop app. tests Pull requests that update or improve our test suite

Comments

@jessfraz
Copy link
Contributor

jessfraz commented Jul 29, 2024 •
edited
Loading

super weird unsure if us or codemirror via cmd+a

could test in the following way

  1. load large file
  2. select all
  3. delete
  4. ensure all code is gone
@jessfraz jessfraz added bug Something isn't working codemirror Bugs related to code mirror. labels Jul 29, 2024
@jessfraz
Copy link
Contributor Author

actually this works in the browser app, will verify it works in the desktop app after release

@jessfraz jessfraz added the desktop-app Issues from the desktop app. label Jul 29, 2024
@jessfraz jessfraz self-assigned this Jul 29, 2024
@jessfraz
Copy link
Contributor Author

jessfraz commented Jul 31, 2024 •
edited
Loading

weird this is still not working in tauri but fine in the ui

@jessfraz
Copy link
Contributor Author

jessfraz commented Aug 4, 2024

this might be fixed with electron port

@jessfraz jessfraz added the tests Pull requests that update or improve our test suite label Aug 13, 2024
@jessfraz jessfraz changed the title select all in code editor does not actually select all, just what is visible Electron test: (regression) select all in code editor does not actually select all, just what is visible Aug 13, 2024
@jessfraz jessfraz removed their assignment Aug 19, 2024
@Irev-Dev Irev-Dev self-assigned this Aug 19, 2024
Irev-Dev added a commit that referenced this issue Aug 19, 2024
@Irev-Dev
select all in code editor does not actually select all, just what is …
e4a39ef 
…visible #3175
@Irev-Dev Irev-Dev mentioned this issue Aug 20, 2024
Merged
Irev-Dev added a commit that referenced this issue Aug 20, 2024
@Irev-Dev
Electron test (regression): select all in code editor does not actual…
2541e0c 
…ly select all, just what is visiable (#3540)

* select all in code editor does not actually select all, just what is visible #3175

* whops

* fix test for linux
@github-actions github-actions bot mentioned this issue Aug 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Irev-Dev Irev-Dev

Labels
bug Something isn't working codemirror Bugs related to code mirror. desktop-app Issues from the desktop app. tests Pull requests that update or improve our test suite
Projects
None yet
Milestone
No milestone
2 participants
@jessfraz @Irev-Dev