Replace tanArc(to) with tanArcTo(relative: true) #3334
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adamchalmers
force-pushed
the
achalmers/remove-tanarc-to
branch
from
0b64dbd to
9f478e8
Compare
docs/kcl/std.json
Outdated
| "summary": "Starting at the current sketch's origin, draw a curved line segment along", | ||
| "description": "some part of an imaginary circle of the specified radius.\nThe arc is constructed such that the last line segment is placed tangent to the imaginary circle of the specified radius. The resulting arc is the segment of the imaginary circle from that tangent point for 'offset' degrees along the imaginary circle.", | ||
| "summary": "Draw a curved line segment along some part of an imaginary circle of the specified radius.", | ||
| "description": "If `relative` is true, the curve starts at the end of the previous path segment (i.e. the location of the \"pen\" which draws these lines). If `relative` is false, starts from the current sketch's origin.\nThe arc is constructed such that the last line segment is placed tangent to the imaginary circle of the specified radius. The resulting arc is the segment of the imaginary circle from that tangent point for 'offset' degrees along the imaginary circle.", |
There was a problem hiding this comment.
@paultag wdyt of my docs here?
There was a problem hiding this comment.
excellent docs; this is great, super good change.
|
I haven't tracked down the exact spot, but I feel like there are a lot of assumptions in TS code about the arguments and their order, like where to put the modeling-app/src/clientSideScene/sceneEntities.ts Line 1206 in 11a94cc |
|
Here's a place that adds a new call. modeling-app/src/lang/std/sketch.ts Lines 812 to 815 in 11a94cc |
adamchalmers
force-pushed
the
achalmers/remove-tanarc-to
branch
from
18ea516 to
1ec2251
Compare
adamchalmers
force-pushed
the
achalmers/remove-tanarc-to
branch
from
1ec2251 to
5c547ef
Compare
There was a problem hiding this comment.
Looks like there's still some last bits to tackle here (some of the 20/20 changes look real flag on behavior change, the draft line for the arc) but the gist here is good - going to mark approved but pending ci/finalization on the rest -- this is great, and a totally needed clenaup. The Arc KCL functions are a bit confusing to use at the moment, thanks for all the work here, this is awesome.
docs/kcl/std.json
Outdated
| "summary": "Starting at the current sketch's origin, draw a curved line segment along", | ||
| "description": "some part of an imaginary circle of the specified radius.\nThe arc is constructed such that the last line segment is placed tangent to the imaginary circle of the specified radius. The resulting arc is the segment of the imaginary circle from that tangent point for 'offset' degrees along the imaginary circle.", | ||
| "summary": "Draw a curved line segment along some part of an imaginary circle of the specified radius.", | ||
| "description": "If `relative` is true, the curve starts at the end of the previous path segment (i.e. the location of the \"pen\" which draws these lines). If `relative` is false, starts from the current sketch's origin.\nThe arc is constructed such that the last line segment is placed tangent to the imaginary circle of the specified radius. The resulting arc is the segment of the imaginary circle from that tangent point for 'offset' degrees along the imaginary circle.", |
There was a problem hiding this comment.
excellent docs; this is great, super good change.
There was a problem hiding this comment.
This looks real, I'm guessing something changed in the program memory?
When sketch mode doesn't know how to draw something it defaults to a straight line.
|
can we merge this? |
|
will leave to @adamchalmers to rebase |
adamchalmers
force-pushed
the
achalmers/remove-tanarc-to
branch
from
e988d79 to
6398359
Compare
adamchalmers
force-pushed
the
achalmers/remove-tanarc-to
branch
from
6398359 to
5e8227e
Compare
|
Replaced by #3705. |
Fixes #3319