Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nadro/3394/project name regression #3609

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Conversation

nadr0
Copy link
Collaborator

@nadr0 nadr0 commented Aug 21, 2024

closes #3394
closes #3521

Background

The original issue reported is not a regression. It is intended behavior. The expected behavior is

  • Start with 0 projects
  • Create a new project and rename it
  • Go through the onboarding
  • See your original project and the default onboarding project

Your original project you created with a custom name is not supposed to be the project used in the onboarding.

Implementation

  • My e2e covers this workflow to make sure the correct number of projects are present, they are named correctly, and the onboarding process works.
  • Updated some any types to use Page from playwright
  • Moved a function that was used 3 times into a shared util since I needed to use it as well. Did not want to copy and paste it for the 3rd time.

Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Aug 21, 2024 9:00pm

Copy link

qa-wolf bot commented Aug 21, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link
Collaborator

@Irev-Dev Irev-Dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, I didn't realise createProjectAndRenameIt was duplicated in two tests.

@jessfraz
Copy link
Contributor

merging since the failures are unrelated

@jessfraz jessfraz merged commit f750c4e into main Aug 22, 2024
18 of 24 checks passed
@jessfraz jessfraz deleted the nadro/3394/project-name-regression branch August 22, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants