Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock the rust toolchain version #3617

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Lock the rust toolchain version #3617

merged 1 commit into from
Aug 22, 2024

Conversation

jtran
Copy link
Collaborator

@jtran jtran commented Aug 22, 2024

This has several benefits:

  • Rust occasionally makes breaking changes, and locking allows us to easily git bisect. Fix build error on Rust 1.80.0 #3128 is an example.
  • Consistent, reproducible builds for a given commit instead of the exact toolchain changing over time
  • New toolchain versions can introduce new, non-trivial warnings which block CI until fixed. Locking prevents a rust release at an arbitrary time from block our team.
  • Documents what version an arbitrary commit was intended to build on

The drawbacks are:

@jtran jtran requested a review from adamchalmers August 22, 2024 16:30
Copy link

qa-wolf bot commented Aug 22, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Aug 22, 2024 4:45pm

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.90%. Comparing base (682099c) to head (11ecf8f).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3617   +/-   ##
=======================================
  Coverage   87.90%   87.90%           
=======================================
  Files          67       67           
  Lines       26150    26150           
=======================================
  Hits        22986    22986           
  Misses       3164     3164           
Flag Coverage Δ
wasm-lib 87.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jessfraz jessfraz merged commit 877eb3e into main Aug 22, 2024
26 of 30 checks passed
@jessfraz jessfraz deleted the jtran/rust-toolchain branch August 22, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants