Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KCL executor: accept and send 'replay' flag, track session data #3646

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

adamchalmers
Copy link
Collaborator

@adamchalmers adamchalmers commented Aug 23, 2024

Part of https://github.com/KittyCAD/engine/issues/2504:

The engine accepts this 'replay' flag now, so, accept it too and send it up to the engine.

Part of KittyCAD/cli#847

The engine sends 'session data' now (like the API Call ID). The CLI executes KCL using this executor, and would like to get the session data after execution.

Copy link

qa-wolf bot commented Aug 23, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Aug 23, 2024 10:20pm

@adamchalmers adamchalmers requested a review from jessfraz August 23, 2024 22:02
@jessfraz
Copy link
Contributor

im not sure this will work til https://github.com/KittyCAD/api-deux/pull/2023 is pulled thru?

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 94.20290% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.90%. Comparing base (4dfad19) to head (f8c5e12).
Report is 3 commits behind head on main.

Files Patch % Lines
src/wasm-lib/kcl/src/executor.rs 85.18% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3646      +/-   ##
==========================================
- Coverage   87.91%   87.90%   -0.01%     
==========================================
  Files          67       67              
  Lines       26105    26127      +22     
==========================================
+ Hits        22950    22968      +18     
- Misses       3155     3159       +4     
Flag Coverage Δ
wasm-lib 87.90% <94.20%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamchalmers
Copy link
Collaborator Author

im not sure this will work til KittyCAD/api-deux#2023 is pulled thru?

I think it'll work via CLI + engine directly, but not through api-deux. That's OK as the former is the intended workflow. But yeah I will get the api-deux PR merged.

@adamchalmers adamchalmers merged commit 6e10f75 into main Aug 23, 2024
24 of 30 checks passed
@adamchalmers adamchalmers deleted the achalmers/send-replay branch August 23, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants