Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut release v0.27.0 #4516

Merged
merged 9 commits into from
Nov 20, 2024
Merged

Cut release v0.27.0 #4516

merged 9 commits into from
Nov 20, 2024

Conversation

pierremtb
Copy link
Collaborator

@pierremtb pierremtb commented Nov 19, 2024

Changed

  • Exported file names now following KCL instead of output
  • Better docs for reduce
  • Better management of file writing
  • JSON removed from the KCL object model
  • BREAKING: KCL has new reserved words that can no longer be used for variable or function names: _ (underscore), as, new, interface, type, record, struct, object, self, array
  • BREAKING: KCL import()'s type: parameter changed to format:

Added

  • Center rectangle
  • Basic horizontal and vertical snapping for Line tool
  • KCL modules and import statements

Fixed

  • Linux AppImage updater
  • Finding path to node for import and if-else
  • Description of angleToMatchLengthX fixed
  • KCL formatting of return values now indents properly

Full Changelog: v0.26.5...v0.27.0

Copy link

qa-wolf bot commented Nov 19, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Nov 20, 2024 3:40pm

@pierremtb pierremtb mentioned this pull request Nov 19, 2024
@pierremtb pierremtb changed the base branch from cut-release-v0.26.6 to main November 19, 2024 19:01
@pierremtb pierremtb marked this pull request as ready for review November 19, 2024 19:44
@pierremtb
Copy link
Collaborator Author

pierremtb commented Nov 20, 2024

Testing out-arm64-mac:

  • Mash keyboard in code editor
  • logging in and authing works
  • external links open an external browser
  • coredump will open github issue with stuff populated (from home and project page) there are different ways to trigger it as well (! button at top, bug at bottom, mod + shift + .)
  • running app.{app,exe} path/to/file opens the kcl file (all oses)
  • running app.{app,exe} path/to/dir opens the directory and any kcl file in it or creates a main.kcl if empty (all oses)
  • If someone at the office, test you can hit make from the app and it works
  • until we have a performance test, sanity check that time to open file directly from command line is not shit
  • ensure we can open files that in tauri we would not be able to
  • double click to open files from finder opens new window each time (mac/windows)
  • export from the app works and opens a file picker ux (needs to be manual since we override for playwright)
  • Token.txt should work | modeling-app#4038
  • Move around and sketch rapidly: is interaction still snappy?
  • Test updating versions works withupdater-test-arm64-mac
  • Ensure that a loading toast appears when testing the auto-updater, saying the download has begun
  • upgrading app should not cause user to have to auth again

@pierremtb
Copy link
Collaborator Author

pierremtb commented Nov 20, 2024

Testing out-x64-win:

  • logging in and authing works
  • external links open an external browser
  • Mash keyboard in code editor
  • coredump will open github issue with stuff populated (from home and project page) there are different ways to trigger it as well (! button at top, bug at bottom, mod + shift + .)
  • running app.{app,exe} path/to/file opens the kcl file (all oses)
  • running app.{app,exe} path/to/dir opens the directory and any kcl file in it or creates a main.kcl if empty (all oses)
  • If someone at the office, test you can hit make from the app and it works
  • until we have a performance test, sanity check that time to open file directly from command line is not shit
  • ensure we can open files that in tauri we would not be able to
  • double click to open files from finder opens new window each time (mac/windows)
  • export from the app works and opens a file picker ux (needs to be manual since we override for playwright)
  • Token.txt should work | modeling-app#4038
  • Move around and sketch rapidly: is interaction still snappy?
  • Test updating versions works withupdater-test-arm64-win
  • Ensure that a loading toast appears when testing the auto-updater, saying the download has begun
  • upgrading app should not cause user to have to auth again

@pierremtb
Copy link
Collaborator Author

pierremtb commented Nov 20, 2024

Testing out-x64-linux:

  • logging in and authing works
  • external links open an external browser
  • Mash keyboard in code editor
  • coredump will open github issue with stuff populated (from home and project page) there are different ways to trigger it as well (! button at top, bug at bottom, mod + shift + .)
  • running app.{app,exe} path/to/file opens the kcl file (all oses)
  • running app.{app,exe} path/to/dir opens the directory and any kcl file in it or creates a main.kcl if empty (all oses)
  • If someone at the office, test you can hit make from the app and it works
  • until we have a performance test, sanity check that time to open file directly from command line is not shit
  • ensure we can open files that in tauri we would not be able to
  • double click to open files from finder opens new window each time (mac/windows)
  • export from the app works and opens a file picker ux (needs to be manual since we override for playwright)
  • Token.txt should work | modeling-app#4038
  • Move around and sketch rapidly: is interaction still snappy?
  • Test updating versions works withupdater-test-x64-mac
  • Ensure that a loading toast appears when testing the auto-updater, saying the download has begun
  • upgrading app should not cause user to have to auth again

@pierremtb pierremtb merged commit 30afa65 into main Nov 20, 2024
27 checks passed
@pierremtb pierremtb deleted the cut-release-v0.27.0 branch November 20, 2024 16:09
@pierremtb
Copy link
Collaborator Author

Extra tests from #4477 (comment)

  • line, arc, rectangle, circle all work in sketch mode
  • moving shapes and points works in sketch mode
  • additional files and directories can be created

@pierremtb pierremtb mentioned this pull request Nov 22, 2024
@pierremtb pierremtb added the release Issue tracking the process of releasing a stable version label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issue tracking the process of releasing a stable version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants