KCL: Change core sketch functions to use keyword args #4826
+123,498
−122,528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adamchalmers
force-pushed
the
achalmers/kw-fn-sketches
branch
2 times, most recently
from
1f6427d to
a61d547
Compare
adamchalmers
force-pushed
the
achalmers/kw-fn-sketches
branch
7 times, most recently
from
68b00f2 to
5f6057f
Compare
adamchalmers
force-pushed
the
achalmers/kw-fn-sketches
branch
from
92360e7 to
f240bbb
Compare
|
I skimmed this and it looks great so far. Does it maintain backward compatibility? If not, the UI needs to generate the new code. |
adamchalmers
force-pushed
the
achalmers/kw-fn-sketches
branch
from
d66bbce to
356b257
Compare
adamchalmers
force-pushed
the
achalmers/kw-fn-sketches
branch
from
101bd66 to
b686ca2
Compare
adamchalmers
force-pushed
the
achalmers/kw-fn-sketches
branch
2 times, most recently
from
41e05c9 to
e99f814
Compare
adamchalmers
force-pushed
the
achalmers/kw-fn-sketches
branch
from
4e8305d to
f678077
Compare
adamchalmers
force-pushed
the
achalmers/kw-fn-sketches
branch
from
962de70 to
9e4b48e
Compare
|
|
Signed-off-by: Nick Cameron <nrc@ncameron.org>
Signed-off-by: Nick Cameron <nrc@ncameron.org>
Signed-off-by: Nick Cameron <nrc@ncameron.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to KCL stdlib:
line(point, sketch, tag)andlineTo(point, sketch, tag)are combined intoline(@sketch, end?, endAbsolute?, tag?)close(sketch, tag?)is nowclose(@sketch, tag?)extrude(length, sketch)is nowextrude(@sketch, length)Part of #4600
Also changes frontend tests to use KittyCAD/kcl-samples#139 instead of its main