Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point-and-click deletion of lofts, shells, and offset planes #4898

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

Point-and-click deletion of lofts, shells, and offset planes #4898

wants to merge 19 commits into from

Conversation

pierremtb
Copy link
Collaborator

@pierremtb pierremtb commented Jan 2, 2025 •
edited
Loading

Closes #4662

Supports:

  • scene selection deletion of lofts
  • feature tree selection deletion of lofts
  • scene selection deletion of offset planes
  • feature tree selection deletion of offset planes

Atm we can't select internal faces of a shell so scene selection deletion of shells is left out here.

TODO before merge:

  • fix kcl error
  • expand existing tests to include these new use cases

@qa-wolf QA Wolf
Copy link

qa-wolf bot commented Jan 2, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@vercel Vercel
Copy link

vercel bot commented Jan 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Jan 6, 2025 10:25pm

@pierremtb pierremtb changed the title WIP: Point-and-click deletion of lofts and offset planes Point-and-click deletion of lofts, shells, and offset planes Jan 2, 2025
@pierremtb pierremtb requested review from nadr0 and franknoirot January 2, 2025 21:35
@pierremtb
Copy link
Collaborator Author

@nadr0 @franknoirot this isn't 100% ready yet but I figured you'd want to be in the loop

pierremtb
pierremtb commented Jan 2, 2025
View reviewed changes
src/machines/modelingMachine.ts
@@ -1689,6 +1658,46 @@ export const modelingMachine = setup({
}
}
),
deleteSelectionAstMod: fromPromise(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't change much here but took the chance to make it promise based like other newer mods

@pierremtb
Copy link
Collaborator Author

Will mark this as ready on Monday after I add the pw test for the new deletion cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadr0 nadr0 Awaiting requested review from nadr0

@franknoirot franknoirot Awaiting requested review from franknoirot

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Point-and-click deletion of Lofts and Offset Planes
1 participant
@pierremtb