-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Release named views to all users #5814
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5814 +/- ##
==========================================
- Coverage 85.83% 85.83% -0.01%
==========================================
Files 113 113
Lines 44484 44484
==========================================
- Hits 38185 38182 -3
- Misses 6299 6302 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
thank you for all the test! |
CodSpeed Walltime Performance ReportMerging #5814 will degrade performances by 11.59%Comparing
|
Benchmark | BASE |
HEAD |
Change | |
---|---|---|---|---|
❌ | execute_walkie-talkie |
4.5 s | 5.1 s | -11.59% |
@nadr0 will review today. |
Fixing up snapshot conflicts so we can merge this beauty |
Issue
Engine + Modeling API was not updated till as of late. We now have the modeling events and API!
Implementation
"@kittycad/lib": "2.0.21",
to support the new APIs.skip_serializing_if = "is_default")]
onNamedView
because I need them explicitly written because when loading them to the engine I need all of the values defined. This cannot be an implicit struct.CameraViewState
toNamedView
and vice versa since the API and NamedView struct ended up with differentts-rs
generated types :(