Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utilities to check platform to determine if a test should run #5983

Merged
merged 7 commits into from
Mar 25, 2025

Conversation

jacebrowning
Copy link
Contributor

@jacebrowning jacebrowning commented Mar 25, 2025

This updates #5941 as we haven't seen a failure of this test on Ubuntu CI in a couple days.

@jacebrowning jacebrowning self-assigned this Mar 25, 2025
Copy link

qa-wolf bot commented Mar 25, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Mar 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Mar 25, 2025 5:12pm

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.79%. Comparing base (81f92bc) to head (03ceedb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5983   +/-   ##
=======================================
  Coverage   85.79%   85.79%           
=======================================
  Files         113      113           
  Lines       44445    44445           
=======================================
  Hits        38132    38132           
  Misses       6313     6313           
Flag Coverage Δ
rust 85.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jacebrowning jacebrowning changed the title Add tests for utility to bypass unreliable tests Add utilities to check platform to determine if a test should run Mar 25, 2025
@jacebrowning jacebrowning marked this pull request as ready for review March 25, 2025 17:15
@jacebrowning jacebrowning requested a review from pierremtb March 25, 2025 17:16
Copy link
Collaborator

@pierremtb pierremtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pierremtb pierremtb merged commit c28bad2 into main Mar 25, 2025
37 checks passed
@pierremtb pierremtb deleted the bypass-per-platform branch March 25, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants