Retry on Abort #33
Merged
Retry on Abort #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason I get very frequent aborts, but on retry I don’t get it. For reference, the server I used for testing was: “openssl s_server -accept 3333 -cert cert.pem -certform PEM -key key.pem -keyform PEM -debug” With this check and repeat, it works
Closed
|
@niklassaers: I've got to revert this change. It causes an infinite loop (see issue #36) if a non-https request is made on the SSL port. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason I get very frequent aborts, but on retry I don’t get it. For reference, the server I used for testing was:
“openssl s_server -accept 3333 -cert cert.pem -certform PEM -key key.pem -keyform PEM -debug”
With this check and repeat, it works
In tandem with Bills update for public init(withCipherSuite cipherSuite: String? = nil, clientAllowsSelfSignedCertificates: Bool = true), this closes #28