Update to support Swift 4.1 #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit d658dc3 Author: ShihabMehboob <shihab.mehboob1@ibm.com> Date: Wed Feb 14 13:18:31 2018 +0000 Updates to Swift 4.1 commit fc48ea6 Author: ShihabMehboob <shihab.mehboob1@ibm.com> Date: Wed Feb 14 13:14:17 2018 +0000 Updates to Swift 4.1 commit 3f2c276 Author: ShihabMehboob <shihab.mehboob1@ibm.com> Date: Wed Feb 14 13:13:56 2018 +0000 Updates to Swift 4.1 commit 664e5ce Author: ShihabMehboob <shihab.mehboob1@ibm.com> Date: Wed Feb 14 13:11:01 2018 +0000 Updates to Swift 4.1 commit 985ea64 Author: ShihabMehboob <shihab.mehboob1@ibm.com> Date: Wed Feb 14 12:52:38 2018 +0000 Updates to Swift 4.1 commit 1f74bb6 Author: ShihabMehboob <shihab.mehboob1@ibm.com> Date: Mon Feb 12 10:27:00 2018 +0000 Support Swift 4.1 commit c86c534 Author: ShihabMehboob <shihab.mehboob1@ibm.com> Date: Thu Feb 8 13:59:20 2018 +0000 Support Swift 4.1
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
==========================================
+ Coverage 53.75% 54.24% +0.49%
==========================================
Files 3 3
Lines 2372 2413 +41
==========================================
+ Hits 1275 1309 +34
- Misses 1097 1104 +7
Continue to review full report at Codecov.
|
.swift-version
Outdated
| @@ -1 +1 @@ | |||
| 3.1.1 | |||
| 4.0 | |||
There was a problem hiding this comment.
Should this be 4.0.3?
|
This looks much, much better. Thanks. If you want, there were a few deprecated functions in the 4.1 build you can address but no big deal, I can address them after the merge. I’ve got some minor surgery today so probably won’t get to the merge until Friday. |
|
@billabt Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update to support Swift 4.1 in reference to this issue: https://github.ibm.com/arf/planning-swift-solutions/issues/571