Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OSX 10.11 deployment target in podspec file. #53

Merged
merged 3 commits into from
Sep 12, 2019

Conversation

mbarnach
Copy link
Member

This PR adds the OSX deployment target in the podspec file, to use CircuitBreaker with CocoaPods dependency management on MacOS. This is required if the Swift Package Manager is not used.

@mbarnach mbarnach changed the title Add OSX 10.10 deployment target in podspec file. Add OSX 10.11 deployment target in podspec file. Jul 22, 2019
@mbarnach
Copy link
Member Author

The failure of the bot doesn't seem to be related to the code I've pushed. Does anyone has an insight on how I can fix it? Thanks.

@djones6
Copy link
Contributor

djones6 commented Sep 12, 2019

@mbarnach The failures are probably the same intermittent failures we've seen for some time (#49). A fix was being worked on in #52 but unfortunately wasn't completed yet. In the meantime I've restarted the failing jobs.

Copy link
Contributor

@djones6 djones6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Apologies for the delay in reviewing.

@djones6 djones6 merged commit 7622e24 into Kitura:master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants