Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update to 4.2.3, official Docker images and enable NIO testing #100

Merged
merged 6 commits into from
Mar 20, 2019

Conversation

djones6
Copy link
Contributor

@djones6 djones6 commented Mar 18, 2019

Description

Motivation and Context

Resolves #91

How Has This Been Tested?

Checklist:

  • I have submitted a CLA form
  • If applicable, I have updated the documentation accordingly.
  • If applicable, I have added tests to cover my changes.

@djones6 djones6 requested a review from pushkarnk March 19, 2019 14:15
@pushkarnk
Copy link
Contributor

@djones6 The only failure in the latest run is with NIO on macOS, which seems to be due to the unavailability of openssl. I think we'd need to add BREW_INSTALL_PACKAGES="libressl" to the corresponding Travis step.

@djones6
Copy link
Contributor Author

djones6 commented Mar 20, 2019

@pushkarnk Thanks - CI is running clean now, so this is ready to review/merge.

Copy link
Contributor

@pushkarnk pushkarnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one question. We seem to have removed all 14.04 builds from Travis. Was that intended?

@pushkarnk pushkarnk merged commit 7029372 into master Mar 20, 2019
@djones6 djones6 deleted the update-ci branch March 22, 2019 16:04
@djones6
Copy link
Contributor Author

djones6 commented Mar 22, 2019

@pushkarnk The removal of 14.04 builds is due to 14.04 shortly going out of service. There will be extended support as a paid offering, but I expect Kitura users will migrate (or have already migrated) to 16.04 or higher. The official Swift Docker images are based on 16.04.

I submitted Kitura/Kitura#1429 to restore one permutation of 14.04 testing for the Kitura repo (this will also cover all Kitura's dependencies), and will retain one similarly in Kitura-Sample (which has a broader set of dependencies including Stencil, Sessions, Credentials, SwiftMetrics - though not CouchDB).

I could be persuaded to reintroduce 14.04 to a broader set of repos if we feel there's real risk of breakage in the future. At the moment I see it as very low risk, confined to places where we directly interact with C libraries (curl, openssl, zlib) that are back-level on 14.04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CouchDB Kitura NIO tests failing on Linux
2 participants