Test: Add Completion statement #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djones6
approved these changes
Dec 17, 2018
|
@Andrew-Lees11 after talking with @ianpartridge we'd like to disable the tests that are failing (the Kitura-NIO builds) and merge this PR. #91 needs to be investigated and the a PR raised to fix the tests (or to re-enable the tests once Kitura-NIO is fixed). |
|
@Andrew-Lees11 I may have fixed this in Kitura/Kitura-NIO#116 (which has now been tagged). I've restarted the failing CI. Edit: we're past that failure, but have uncovered a new one. I've updated #91 accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a completion statement to
dropDatabaseIfExistsso that if there isn't a database it will still call the next function and continue the tests.Also changed the default database name in the tests to the suggested local database to help when testing locally.