-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClientRequest auth should use an Authorization header #178
Milestone
Comments
We discovered that for Kitura-net, Need to confirm whether the same happens for Kitura-NIO. |
This was merged (for Kitura-NIO). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In #171 we noted that currently, the username and password fields are being sent as part of the URL for basic authentication, and that they are currently not percent-escaped by the NIO client.
Rather than escaping them, I believe they should instead be sent in an
Authorization
header. This would alleviate the need to escape their values, besides being recommended practice. Normally the Authorization header is sent in response to a server sending aWWW-Authenticate
header, but I believe it's valid to provide it outside of that flow.This would be a behavioural (breaking?) change as the format of the URL would change where basic authentication is being used, and would require recipients to support parsing the Authorization header (which I believe they should do, but I can imagine there may be implementations out there that assumes they'll be tacked on to the URL).
Both Kitura-NIO and Kitura-net would need to be changed to behave consistently.
The text was updated successfully, but these errors were encountered: