Send Basic Auth credentials in an Authorization header #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 14, 2019 15:28
The username and password are currently sent as a part of the url. This can be a challenge if the url need to be percent encoded. The username and password also need to be percent encoded then. It is easier to send username and password in the Authorization header. Note that this will change the behaviour of `ClientRequent.url`.
pushkarnk
suggested changes
Jul 22, 2019
| @@ -269,12 +269,12 @@ public class ClientRequest { | |||
| } | |||
| self.path = fullPath | |||
|
|
|||
| if let username = url.user { | |||
There was a problem hiding this comment.
We must retain this code. The username and password will continue to be accessible using the userName and password properties. They only won't be included in the url property.
added 2 commits
July 22, 2019 14:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The username and password are currently sent as a part of the url. This can be a challenge
if the url need to be percent encoded. The username and password also need to be percent
encoded then. It is easier to send username and password in the Authorization header. Note that
this will change the behaviour of
ClientRequent.url.This is for #178 . It is a breaking change.