tests: introduce a compiler flag to enable ephemeral ports #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owing to a limitation in ClientRequest, the use of ephemeral ports needs configuration of the ephemeral port range. This configuration is done using the `sysctl` command on both Linux and macOS. While sysctl appears to be working without sudo permissions on Linux, it needs sudo on macOS. This forces `swift test` to stop at the password prompt. This behaviour change needs to be avoided. This commit makes the use of ephemeral ports optional by introducing a compiler flag called `USE_EPHEMERAL_PORTS`. To run Kitura-NIO tests with ephemeral ports issue: `swift test -Xswiftc -DUSE_EPHEMERAL_PORTS On Travis CI, we could continue using ephemeral ports on both macOS and Linux. For this, the `.swift-test-macOS` and `.swift-test-linux` are added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Owing to a limitation in ClientRequest, the use of ephemeral ports needs configuration of the ephemeral port range. This configuration is done using the
sysctlcommand on both Linux and macOS. While sysctl appears to be working without sudo permissions on Linux, it needs sudo on macOS. This forcesswift testto stop at the password prompt. This behaviour change needs to be avoided. This commit makes the use of ephemeral ports optional by introducing a compiler flag calledUSE_EPHEMERAL_PORTS.To run Kitura-NIO tests with ephemeral ports issue:
swift test -Xswiftc -DUSE_EPHEMERAL_PORTSOn Travis CI, we could continue using ephemeral ports on both macOS and Linux. For this, the
.swift-test-macOSand.swift-test-linuxare added.