HTTPServerRequest: Build urlURL using URLComponents

[nethraravindran]

This increases the performance by ~2% while accessingurlURL

[pushkarnk]

@nethraravindran Bridging UInt16 to NSNumber doesn't work pre-4.2. We have two options:

1. replace it by NSNumber(value:) all throughout
2. do (1) only for pre-4.2 compiler versions

I ran a small benchmark and find performance of NSNumber(value:) similar to x as NSNumber. So, we may adopt (1).

[nethraravindran]

@pushkarnk I have addressed the changes. Please review. Thank you!

[pushkarnk]

Performance apart, this seems like a better way of building urlURL.

[ianpartridge]

I have no problem with this in principle, but we are creating a NSURLComponents() and throwing it away. We also have this property (line 43):

public var urlComponents: URLComponents

so could we cache the URLComponents we create and use it in that property? This all seems a bit messy at the moment.

[codecov-io]

Codecov Report

Merging #143 into master will decrease coverage by 0.15%.
The diff coverage is 62.5%.

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
- Coverage   67.11%   66.95%   -0.16%     
==========================================
  Files          20       20              
  Lines        1271     1274       +3     
==========================================
  Hits          853      853              
- Misses        418      421       +3

Flag	Coverage Δ
#KituraNet	66.95% <62.5%> (-0.16%)	⬇️

Impacted Files	Coverage Δ
Sources/KituraNet/HTTP/HTTPServerRequest.swift	70.37% <62.5%> (-1.33%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 242c40a...46fbee0. Read the comment docs.

[pushkarnk]

@nethraravindran We must cache it here as well, in the scenario where urlComponents was invoked before urlURL

[nethraravindran]

@pushkarnk Sure!

[pushkarnk]

check if _urlComponents already exists here, we could have initialised it in urlComponents