Create Data using String.utf8 instead of NSString.data(using:) #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
==========================================
+ Coverage 66.84% 66.87% +0.02%
==========================================
Files 20 20
Lines 1300 1298 -2
==========================================
- Hits 869 868 -1
+ Misses 431 430 -1
Continue to review full report at Codecov.
|
ianpartridge
reviewed
Feb 6, 2019
| @@ -55,7 +55,7 @@ public class FastCGIServerRequest: ServerRequest { | |||
| /// The URL from the request in UTF-8 form | |||
| /// This contains just the path and query parameters starting with '/' | |||
| /// Use 'urlURL' for the full URL | |||
| public var url: Data { return requestUri?.data(using: .utf8) ?? Data() } | |||
| public var url: Data { return Data(urlURL.absoluteString.utf8) } | |||
There was a problem hiding this comment.
Why was this changed to use urlURL rather than requestUri? The comment above says they are different.
There was a problem hiding this comment.
@ianpartridge Thanks for finding this. I've fixed it.
pushkarnk
force-pushed
the
data-from-utf8view
branch
from
a3d35df
to
fed5f1c
Compare
ianpartridge
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have
string.data(using:)to create Data in a handful of places. This will be sub-optimal given that it implicitly goes through NSString, which is currently a known performance bottleneck in Swift 5.This is on the lines of Kitura/Kitura#1395