Fix to set property ClientResponse.status right #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kitura-NIO wrongly returned -1 as status code.The property ClientResponse.status now updates when ClientResponse.statusCode is updated.Observer didSet is removed from ClientResponse.status as observers of both status and statusCode trigger each other and cause stackoverflow.The changes made ensure the property ClientResonse.status is set right.
|
|
The changes have been tested with:
|
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kitura-NIO wrongly returned -1 as status code.The property
ClientResponse.status now updates when ClientResponse.statusCode is
updated.Observer didSet is removed from ClientResponse.status as observers of
both status and statusCode trigger each other and cause stackoverflow.The
changes made ensure the property ClientResonse.status is set right.