Add api to access eventloopGroup in Kitura-NIO #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djones6
reviewed
Oct 9, 2019
harish1992
force-pushed
the
eventLoopGroup
branch
from
6a7f631
to
2537bf1
Compare
djones6
reviewed
Oct 17, 2019
djones6
reviewed
Oct 17, 2019
djones6
reviewed
Oct 17, 2019
djones6
reviewed
Oct 17, 2019
djones6
added a commit
that referenced
this pull request
Oct 18, 2019
- required due to possibility of calling syncShutdownGracefully() on an EventLoop. Can be reverted once #225 is merged.
This was referenced Oct 18, 2019
added 8 commits
October 21, 2019 14:42
EventLoopGroup `eventloopGroup` was inacessible in previous versions of Kitura-NIO. This PR makes `eventLoopGroup` a public api and also provides a way to start HTTPserver with user created EventLoopGroup.
harish1992
force-pushed
the
eventLoopGroup
branch
from
2537bf1
to
605fd3f
Compare
djones6
approved these changes
Oct 22, 2019
harish1992
added
the
jazzy-doc
djones6
reviewed
Oct 22, 2019
pushkarnk
reviewed
Oct 23, 2019
pushkarnk
reviewed
Oct 23, 2019
pushkarnk
reviewed
Oct 23, 2019
pushkarnk
reviewed
Oct 23, 2019
pushkarnk
reviewed
Oct 23, 2019
pushkarnk
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventLoopGroup
eventloopGroupwas inacessible in previous versions ofKitura-NIO. This PR makes
eventLoopGroupa public api and also provides a wayto start HTTPserver with user created EventLoopGroup.