Execute tasks on the event loop - refactor #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nethra Ravindran seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
| } | ||
|
|
||
| /// Executes task on event loop | ||
| private func runOnEventLoop(channel: Channel, _ task: @escaping () -> Void) { |
There was a problem hiding this comment.
Can we do the same execute(on: channel.eventLoop) here and reuse code?
nethraravindran
force-pushed
the
runOnEventLoop
branch
2 times, most recently
from
d9ba6e1
to
9b93523
Compare
nethraravindran
commented
Aug 30, 2018
| do { | ||
| try self.end0(channel: channel) | ||
| } catch let error { | ||
| fatalError("Error: \(error)") |
There was a problem hiding this comment.
@pushkarnk should we crash here?
There was a problem hiding this comment.
I don't think we should crash at these places. We must simply Log.error() and return. We need to do all of that in a separate PR though.
nethraravindran
force-pushed
the
runOnEventLoop
branch
from
9b93523
to
9a1a479
Compare
pushkarnk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.