New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not store the HTTPDummyServerDelegate object #96

Merged

pushkarnk merged 1 commit into Kitura:master from pushkarnk:remove-dummy-delegate

Sep 25, 2018

Commits on Sep 24, 2018

Do not store the HTTPDummyServerDelegate object

Kitura-Net keeps the HTTP server running even if a delegate isn't provided. We use a HTTPDummyServerDelegate for this purpose. Before this code change, we stored the dummy delegate in the delegate property of HTTPServer. This may be confusing to a user who will rightly think that delegate is nil if it isn't explicitly set.

Pushkar Kulkarni committed Sep 24, 2018