Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port OpenSSL 2.x changes to OpenSSL 1.x #16

Merged
merged 1 commit into from
Dec 11, 2018

Conversation

nethraravindran
Copy link
Contributor

No description provided.

Package.swift Outdated Show resolved Hide resolved
Copy link
Contributor

@djones6 djones6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restore the Package.swift to the old Swift 3 format. Otherwise, looks good.

Since there is no Travis, can you run a build of a dependent project (eg. BlueSSLService or Swift-JWK-to-PEM) using your branch, and link the passing Travis build here?

Copy link
Collaborator

@billabt billabt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the changes requested by @djones6.

@billabt
Copy link
Collaborator

billabt commented Dec 11, 2018

@djones6 As soon as you're satisfied, I'll do the merge and tag it... Thanks.

@djones6
Copy link
Contributor

djones6 commented Dec 11, 2018

@nethraravindran thanks for the testing.
@billabt This looks good now. We'll need a 1.0.2 tag on the toolsVersion40 branch.

@billabt billabt merged commit a39f934 into Kitura:toolsVersion40 Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants