Skip to content

Commit

Permalink
Fix missing labels in queryTests.php table (#2202)
Browse files Browse the repository at this point in the history
#1455 mistakenly used the test ID instead of the test output ID to find
labels for the queryTests page. This issue was separately resolved in
the 3.5 release series by the refactor in #2148.

Failures like this are a good motivation for our effort to move to a
GraphQL API. With GraphQL, there is a single source of truth about where
labels come from, and there isn't a need to separately query the labels
in dozens of different locations. These types of failures are also a
good motivation for more complete testing data, with most tables having
at least thousands of rows. With limited data, this failure went
unnoticed because each test ID corresponds to a test output ID in the
testing environment. This limited issue was resolved by the removal of
the test table in #2148.
  • Loading branch information
williamjallen authored May 9, 2024
1 parent 5831cce commit 4e8332f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/cdash/app/Controller/Api/QueryTests.php
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ public function getResponse()
label2test
WHERE
label.id=label2test.labelid
AND label2test.outputid=test.id
AND label2test.outputid=build2test.outputid
AND label2test.buildid=b.id
) AS labelstring
$output_select
Expand Down

0 comments on commit 4e8332f

Please sign in to comment.