Bump phpstan/phpstan from 1.10.15 to 1.10.36 (#1737)

Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan) from 1.10.15 to 1.10.36. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/phpstan/phpstan/releases">phpstan/phpstan's releases</a>.</em></p> <blockquote> <h2>1.10.36</h2> <h1>Improvements 🔧</h1> <ul> <li>DumpParametersCommand: <code>--json</code> option (<a href="https://github.com/phpstan/phpstan-src/commit/91a0002402123b96a08978ba400b5d76d5456693">https://github.com/phpstan/phpstan-src/commit/91a0002402123b96a08978ba400b5d76d5456693</a>)</li> <li>Implement <code>reportUncheckedExceptionDeadCatch</code> option (defaults to <code>true</code>) (<a href="https://redirect.github.com/phpstan/phpstan-src/pull/2648">#2648</a>), <a href="https://redirect.github.com/phpstan/phpstan/issues/9921">#9921</a>, thanks <a href="https://github.com/VincentLanglet"><code>@VincentLanglet</code></a>!</li> <li>Support union types in <code>array_chunk()</code> (<a href="https://redirect.github.com/phpstan/phpstan-src/pull/2635">#2635</a>), thanks <a href="https://github.com/staabm"><code>@staabm</code></a>!</li> <li>Result cache: Indicate key differences in cache metadata (<a href="https://redirect.github.com/phpstan/phpstan-src/pull/2630">#2630</a>), thanks <a href="https://github.com/staabm"><code>@staabm</code></a>!</li> <li>Get rid of annoying "on an unknown class ReflectionEnum" error on PHP < 8.0 (<a href="https://github.com/phpstan/phpstan-src/commit/2b9af363a3d2a9620c4b9bfb65e81813b69623d0">https://github.com/phpstan/phpstan-src/commit/2b9af363a3d2a9620c4b9bfb65e81813b69623d0</a>)</li> </ul> <h1>Bugfixes 🐛</h1> <ul> <li>Fix resolving nested conditional types with union subjects (<a href="https://redirect.github.com/phpstan/phpstan-src/pull/2641">#2641</a>), <a href="https://redirect.github.com/phpstan/phpstan/issues/9860">#9860</a>, thanks <a href="https://github.com/rvanvelzen"><code>@rvanvelzen</code></a>!</li> <li>Detect array_rand second parameter (<a href="https://redirect.github.com/phpstan/phpstan-src/pull/2633">#2633</a>), <a href="https://redirect.github.com/phpstan/phpstan/issues/9803">#9803</a>, thanks <a href="https://github.com/staabm"><code>@staabm</code></a>!</li> <li>Fix subtracting types from union template types (<a href="https://redirect.github.com/phpstan/phpstan-src/pull/2652">#2652</a>), <a href="https://redirect.github.com/phpstan/phpstan/issues/9939">#9939</a>, thanks <a href="https://github.com/rvanvelzen"><code>@rvanvelzen</code></a>!</li> <li>fix infinite cycle due to incorrect implements/extends (<a href="https://redirect.github.com/phpstan/phpstan-src/pull/2483">#2483</a>), thanks <a href="https://github.com/schlndh"><code>@schlndh</code></a>!</li> <li>Fix ConstantFloatType value dump precision (<a href="https://redirect.github.com/phpstan/phpstan-src/pull/2358">#2358</a>), thanks <a href="https://github.com/mvorisek"><code>@mvorisek</code></a>!</li> <li>Do not trigger PhpDocInheritanceResolver if we do not need the PHPDoc type when resolving the type of ClassConstFetch (<a href="https://redirect.github.com/phpstan/phpstan-src/pull/2414">#2414</a>), <a href="https://redirect.github.com/phpstan/phpstan/issues/9039">#9039</a>, thanks <a href="https://github.com/VincentLanglet"><code>@VincentLanglet</code></a>!</li> </ul> <h1>Function signature fixes 🤖</h1> <ul> <li><code>connection_*</code> functions are impure (<a href="https://redirect.github.com/phpstan/phpstan-src/pull/2555">#2555</a>), thanks <a href="https://github.com/staabm"><code>@staabm</code></a>!</li> <li>Add stubs for <code>mysqli</code> and <code>mysqli_result</code> classes (<a href="https://redirect.github.com/phpstan/phpstan-src/pull/2295">#2295</a>), thanks <a href="https://github.com/phansys"><code>@phansys</code></a>!</li> </ul> <h1>Internals 🔍</h1> <ul> <li>E2E test about env variables in config parameters (<a href="https://github.com/phpstan/phpstan-src/commit/980ab5bba4de0246587647e8cf6b7abe95697379">https://github.com/phpstan/phpstan-src/commit/980ab5bba4de0246587647e8cf6b7abe95697379</a>)</li> <li>Prevent unnecessary calls to <code>getFiniteTypes()</code> (<a href="https://redirect.github.com/phpstan/phpstan-src/pull/2636">#2636</a>), thanks <a href="https://github.com/staabm"><code>@staabm</code></a>!</li> <li>Remove unnecessary IO (<a href="https://redirect.github.com/phpstan/phpstan-src/pull/2613">#2613</a>), thanks <a href="https://github.com/staabm"><code>@staabm</code></a>!</li> <li>Restrict "Merge maintained branch" workflow to the main repository (<a href="https://redirect.github.com/phpstan/phpstan-src/pull/2654">#2654</a>), thanks <a href="https://github.com/thg2k"><code>@thg2k</code></a>!</li> </ul> <h2>1.10.35</h2> <h1>Major new features 🚀</h1> <ul> <li>Generics: <strong>Type projections aka call-site variance</strong> (<a href="https://redirect.github.com/phpstan/phpstan-src/pull/2485">#2485</a>), thanks <a href="https://github.com/jiripudil"><code>@jiripudil</code></a>! <ul> <li>Learn more: <a href="https://phpstan.org/blog/guide-to-call-site-generic-variance">https://phpstan.org/blog/guide-to-call-site-generic-variance</a></li> </ul> </li> </ul> <h1>Bugfixes 🐛</h1> <ul> <li>Make <code>value-of<...></code> lazier (<a href="https://github.com/phpstan/phpstan-src/commit/234f77d652bf6326be4bf5c25c7aab67145aca71">https://github.com/phpstan/phpstan-src/commit/234f77d652bf6326be4bf5c25c7aab67145aca71</a>), <a href="https://redirect.github.com/phpstan/phpstan/issues/9881">#9881</a></li> <li>Update BetterReflection, <a href="https://redirect.github.com/phpstan/phpstan/issues/9877">#9877</a> <ul> <li>Fix <code>ReflectionAttribute::newInstance()</code> with nested class using named arguments (<a href="https://github.com/ondrejmirtes/BetterReflection/commit/8d751dd38f4d089715e748863d0d8e4113bc408c">https://github.com/ondrejmirtes/BetterReflection/commit/8d751dd38f4d089715e748863d0d8e4113bc408c</a>), thanks <a href="https://github.com/enumag"><code>@enumag</code></a>!</li> </ul> </li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/phpstan/phpstan/commit/ffa3089511121a672e62969404e4fddc753f9b15"><code>ffa3089</code></a> PHPStan 1.10.36</li> <li><a href="https://github.com/phpstan/phpstan/commit/5b84f9f88af7bdeed04907c46953a92ff713af71"><code>5b84f9f</code></a> Updated PHPStan to commit 5b84f9f0da56e377ee56730d82f28b0a9c6caabe</li> <li><a href="https://github.com/phpstan/phpstan/commit/2b9af365ac4cf85e6ac2f1c4375791acdd13c7cb"><code>2b9af36</code></a> Updated PHPStan to commit 2b9af363a3d2a9620c4b9bfb65e81813b69623d0</li> <li><a href="https://github.com/phpstan/phpstan/commit/dcfa3b1bf62ddc591d53363bb1c0455a889e0e7c"><code>dcfa3b1</code></a> Updated PHPStan to commit dcfa3b11b5d15b5f3f51fd1bcdcfbd90522f9df6</li> <li><a href="https://github.com/phpstan/phpstan/commit/7db91667f6a82ff2a59b6d5036a9879d460492d5"><code>7db9166</code></a> Update baselines</li> <li><a href="https://github.com/phpstan/phpstan/commit/65cda8b33d2d250980ab18b2a98601aaf51561a5"><code>65cda8b</code></a> Updated PHPStan to commit 65cda8b95caa36fb5abe807bd7c03a91eab14e6f</li> <li><a href="https://github.com/phpstan/phpstan/commit/e3023e08d78fc6c362268de9c08d4b47cacde0f2"><code>e3023e0</code></a> Updated PHPStan to commit e3023e0c451fb62030fe08b78039a5480d89a912</li> <li><a href="https://github.com/phpstan/phpstan/commit/d25b89748fe1d431244c38a2de14366590791bc0"><code>d25b897</code></a> Updated PHPStan to commit d25b897cc6671e7042cf669c9efe3ec05dde1a47</li> <li><a href="https://github.com/phpstan/phpstan/commit/2011cfef67b4daa5b7309f5e12086ee23132fea1"><code>2011cfe</code></a> Updated PHPStan to commit 2011cfe035b01980f92f894b003ac9a93317469f</li> <li><a href="https://github.com/phpstan/phpstan/commit/cbefca4ac51321eeb1d1586d649f8e8029ff78de"><code>cbefca4</code></a> Updated PHPStan to commit cbefca4caf56679d53c86cc08b3d46b7de1fcc5c</li> <li>Additional commits viewable in <a href="https://github.com/phpstan/phpstan/compare/1.10.15...1.10.36">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=phpstan/phpstan&package-manager=composer&previous-version=1.10.15&new-version=1.10.36)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: William Allen <16820599+williamjallen@users.noreply.github.com>
Kitware · Nov 3, 2023 · 69e5de5 · 69e5de5
1 parent 695329c
commit 69e5de5
Show file tree

Hide file tree

Showing 4 changed files with 41 additions and 16 deletions.
diff --git a/composer.json b/composer.json
@@ -51,7 +51,7 @@
  "mockery/mockery": "1.5.1",
  "nunomaduro/larastan": "2.5.1",
  "phpstan/extension-installer": "1.3.1",
- "phpstan/phpstan": "1.10.15",
+ "phpstan/phpstan": "1.10.36",
  "phpstan/phpstan-deprecation-rules": "1.1.4",
  "phpstan/phpstan-mockery": "1.1.1",
  "phpstan/phpstan-phpunit": "1.3.10",

diff --git a/composer.lock b/composer.lock
diff --git a/package-lock.json b/package-lock.json
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -1176,6 +1176,11 @@ parameters:
  count: 2
  path: app/Http/Controllers/SubProjectController.php
 
+ -
+ message: "#^Only booleans are allowed in an if condition, int given\\.$#"
+ count: 1
+ path: app/Http/Controllers/SubProjectController.php
+
  -
  message: "#^Only booleans are allowed in an if condition, mixed given\\.$#"
  count: 1
@@ -1906,6 +1911,11 @@ parameters:
  count: 1
  path: app/Services/AuthTokenService.php
 
+ -
+ message: "#^Method App\\\\Services\\\\AuthTokenService\\:\\:generateToken\\(\\) throws checked exception Random\\\\RandomException but it's missing from the PHPDoc @throws tag\\.$#"
+ count: 1
+ path: app/Services/AuthTokenService.php
+
  -
  message: "#^Method App\\\\Services\\\\AuthTokenService\\:\\:isTokenExpired\\(\\) throws checked exception LogicException but it's missing from the PHPDoc @throws tag\\.$#"
  count: 1
@@ -1979,6 +1989,11 @@ parameters:
  count: 2
  path: app/Services/TestCreator.php
 
+ -
+ message: "#^Method App\\\\Services\\\\TestCreator\\:\\:create\\(\\) throws checked exception PDOException but it's missing from the PHPDoc @throws tag\\.$#"
+ count: 2
+ path: app/Services/TestCreator.php
+
  -
  message: "#^Method App\\\\Services\\\\TestCreator\\:\\:saveImage\\(\\) has parameter \\$outputid with no type specified\\.$#"
  count: 1
@@ -2684,7 +2699,7 @@ parameters:
  path: app/cdash/app/Controller/Api/ResultsApi.php
 
  -
- message: "#^Only booleans are allowed in a negated boolean, float\\|int given\\.$#"
+ message: "#^Only booleans are allowed in a negated boolean, \\(float\\|int\\) given\\.$#"
  count: 1
  path: app/cdash/app/Controller/Api/ResultsApi.php
 
@@ -7329,6 +7344,11 @@ parameters:
  count: 1
  path: app/cdash/app/Model/Image.php
 
+ -
+ message: "#^Method CDash\\\\Model\\\\Image\\:\\:Save\\(\\) throws checked exception PDOException but it's missing from the PHPDoc @throws tag\\.$#"
+ count: 1
+ path: app/cdash/app/Model/Image.php
+
  -
  message: "#^Only booleans are allowed in a negated boolean, mixed given\\.$#"
  count: 1
@@ -12017,6 +12037,11 @@ parameters:
  count: 1
  path: app/cdash/include/common.php
 
+ -
+ message: "#^Function generate_password\\(\\) throws checked exception Random\\\\RandomException but it's missing from the PHPDoc @throws tag\\.$#"
+ count: 1
+ path: app/cdash/include/common.php
+
  -
  message: "#^Function getByteValueWithExtension\\(\\) has parameter \\$base with no type specified\\.$#"
  count: 1
@@ -13382,6 +13407,11 @@ parameters:
  count: 1
  path: app/cdash/include/pdo.php
 
+ -
+ message: "#^Function pdo_insert_id\\(\\) throws checked exception PDOException but it's missing from the PHPDoc @throws tag\\.$#"
+ count: 1
+ path: app/cdash/include/pdo.php
+
  -
  message: "#^Function pdo_real_escape_numeric\\(\\) never returns float so it can be removed from the return type\\.$#"
  count: 1
@@ -20691,11 +20721,6 @@ parameters:
  count: 1
  path: app/cdash/tests/kwtest/kw_web_tester.php
 
- -
- message: "#^Result of && is always false\\.$#"
- count: 1
- path: app/cdash/tests/kwtest/kw_web_tester.php
-
  -
  message: "#^Return type \\(CDashControllerUserAgent\\) of method CDashControllerBrowser\\:\\:createUserAgent\\(\\) should be covariant with return type \\(SimpleFetcher\\) of method SimpleBrowser\\:\\:createUserAgent\\(\\)$#"
  count: 1
@@ -29188,7 +29213,7 @@ parameters:
  path: app/cdash/xml_handlers/upload_handler.php
 
  -
- message: "#^Property UploadHandler\\:\\:\\$BuildId is unused\\.$#"
+ message: "#^Property UploadHandler\\:\\:\\$BuildId is never read, only written\\.$#"
  count: 1
  path: app/cdash/xml_handlers/upload_handler.php