Migrate CoverageSummaryDiff model to Eloquent

app/Models/CoverageSummaryDiff.php

@@ -0,0 +1,28 @@
+<?php
+
+namespace App\Models;
+
+use Illuminate\Database\Eloquent\Builder;
+use Illuminate\Database\Eloquent\Model;
+
+/**
+ * @property int $buildid
+ * @property int $loctested
+ * @property int $locuntested
+ *
+ * @mixin Builder<CoverageSummaryDiff>
+ */
+class CoverageSummaryDiff extends Model
+{
+ protected $table = 'coveragesummarydiff';
+
+ public $timestamps = false;
+
+ protected $primaryKey = 'buildid';
+
+ protected $fillable = [
+ 'buildid',
+ 'loctested',
+ 'locuntested',
+ ];
+}

app/cdash/app/Model/CoverageSummary.php

@@ -15,6 +15,7 @@
 =========================================================================*/
 namespace CDash\Model;
 
+use App\Models\CoverageSummaryDiff;
 use CDash\Database;
 use Illuminate\Support\Facades\DB;
 
@@ -326,17 +327,17 @@ public function ComputeDifference($previous_parentid=null): bool
  $previousloctested = intval($previouscoverage['loctested']);
  $previouslocuntested = intval($previouscoverage['locuntested']);
 
- $summaryDiff = new CoverageSummaryDiff();
- $summaryDiff->BuildId = $this->BuildId;
  $loctesteddiff = $loctested - $previousloctested;
  $locuntesteddiff = $locuntested - $previouslocuntested;
 
- // Don't log if no diff unless an entry already exists
- // for this build.
- if ($summaryDiff->Exists() || $loctesteddiff !== 0 || $locuntesteddiff !== 0) {
- $summaryDiff->LocTested = $loctesteddiff;
- $summaryDiff->LocUntested = $locuntesteddiff;
- $summaryDiff->Insert();
+ // Don't log if no diff unless an entry already exists for this build.
+ if (CoverageSummaryDiff::where(['buildid' => $this->BuildId])->exists() || $loctesteddiff !== 0 || $locuntesteddiff !== 0) {
+ CoverageSummaryDiff::updateOrCreate([
+ 'buildid' => $this->BuildId,
+ ], [
+ 'loctested' => $loctesteddiff,
+ 'locuntested' => $locuntesteddiff,
+ ]);
  }
  }
 

phpstan-baseline.neon

@@ -6950,6 +6950,11 @@ parameters:
  count: 11
  path: app/cdash/app/Model/CoverageSummary.php
 
+ -
+ message: "#^Dynamic call to static method Illuminate\\\\Database\\\\Eloquent\\\\Builder\\<App\\\\Models\\\\CoverageSummaryDiff\\>\\:\\:exists\\(\\)\\.$#"
+ count: 1
+ path: app/cdash/app/Model/CoverageSummary.php
+
  -
  message: "#^Method CDash\\\\Model\\\\CoverageSummary\\:\\:AddCoverage\\(\\) has parameter \\$coverage with no type specified\\.$#"
  count: 1
@@ -7035,50 +7040,6 @@ parameters:
  count: 1
  path: app/cdash/app/Model/CoverageSummary.php
 
- -
- message: """
- #^Call to deprecated function add_last_sql_error\\(\\)\\:
- 04/22/2023$#
- """
- count: 1
- path: app/cdash/app/Model/CoverageSummaryDiff.php
-
- -
- message: """
- #^Call to deprecated method executePrepared\\(\\) of class CDash\\\\Database\\:
- 04/22/2023 Use Laravel query builder or Eloquent instead$#
- """
- count: 2
- path: app/cdash/app/Model/CoverageSummaryDiff.php
-
- -
- message: """
- #^Call to deprecated method executePreparedSingleRow\\(\\) of class CDash\\\\Database\\:
- 04/22/2023 Use Laravel query builder or Eloquent instead$#
- """
- count: 2
- path: app/cdash/app/Model/CoverageSummaryDiff.php
-
- -
- message: "#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#"
- count: 1
- path: app/cdash/app/Model/CoverageSummaryDiff.php
-
- -
- message: "#^Property CDash\\\\Model\\\\CoverageSummaryDiff\\:\\:\\$BuildId has no type specified\\.$#"
- count: 1
- path: app/cdash/app/Model/CoverageSummaryDiff.php
-
- -
- message: "#^Property CDash\\\\Model\\\\CoverageSummaryDiff\\:\\:\\$LocTested has no type specified\\.$#"
- count: 1
- path: app/cdash/app/Model/CoverageSummaryDiff.php
-
- -
- message: "#^Property CDash\\\\Model\\\\CoverageSummaryDiff\\:\\:\\$LocUntested has no type specified\\.$#"
- count: 1
- path: app/cdash/app/Model/CoverageSummaryDiff.php
-
  -
  message: """
  #^Call to deprecated function add_last_sql_error\\(\\)\\: