CDash OAuth login assumes "First Last" for name back from Provider #2435
Comments
josephsnyder
added a commit
to josephsnyder/CDash
that referenced
this issue
Sep 9, 2024
Per a bug report, if an OAuth account name doesn't use a real name, CDash will 500 if a space doesn't exist in the name. Check for the space before trying to separate into first and last names. If no space, use the whole string as the first name. Fixes: Kitware#2435
josephsnyder
added a commit
to josephsnyder/CDash
that referenced
this issue
Sep 9, 2024
Per a bug report, if an OAuth account name doesn't use a real name, CDash will 500 if a space doesn't exist in the name. Check for the space before trying to separate into first and last names. If no space, use the whole string as the first name. Fixes: Kitware#2435
josephsnyder
added a commit
to josephsnyder/CDash
that referenced
this issue
Sep 9, 2024
Per a bug report, if an OAuth account name doesn't use a real name, CDash will 500 if a space doesn't exist in the name. Check for the space before trying to separate into first and last names. If no space, use the whole string as the first name. Fixes: Kitware#2435
josephsnyder
added a commit
to josephsnyder/CDash
that referenced
this issue
Sep 9, 2024
Per a bug report, if an OAuth account name doesn't use a real name, CDash will 500 if a space doesn't exist in the name. Check for the space before trying to separate into first and last names. If no space, use the whole string as the first name. Fixes: Kitware#2435
josephsnyder
added a commit
to josephsnyder/CDash
that referenced
this issue
Sep 10, 2024
Per a bug report, if an OAuth account name doesn't use a real name, CDash will 500 if a space doesn't exist in the name. Check for the space before trying to separate into first and last names. If no space, use the whole string as the first name. Fixes: Kitware#2435
josephsnyder
added a commit
to josephsnyder/CDash
that referenced
this issue
Sep 11, 2024
Per a bug report, if an OAuth account name doesn't use a real name, CDash will 500 if a space doesn't exist in the name. Check for the space before trying to separate into first and last names. If no space, use the whole string as the first name. Fixes: Kitware#2435
github-merge-queue bot
pushed a commit
that referenced
this issue
Sep 11, 2024
Per a bug report, if an OAuth account name doesn't use a real name, CDash will 500 if a space doesn't exist in the name. Check for the space before trying to separate into first and last names. If no space, use the whole string as the first name. Fixes: #2435
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug report
Expected Behavior
If an OAuth provider doesn't return the full name,
'First Last', of the user but instead sends back the login name, CDash should not attempt to break the name into first and last name variables for the user.Actual Behavior
CDash returned a 500 error:
production. ERROR: Undefined array key 1 {"exception":[object] {ErrorException(code: 0): Undefined array key 1 at /opt/CDash/CDash-3.5.0/app/Http/Controllers/OAuthController.php:39)We should see if the name contains a space and proceed with the
explodeif it exists. If it doesn't, use the whole name string as the first name?CDash Version
Additional Information
See discussion:
#2434
The text was updated successfully, but these errors were encountered: