Apply all "safe" PHP migration style rules #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephsnyder
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Each commit makes sense and I don't see any issue with the resulting CDash instance!
I'll leave the documentation link about each migration that you sent here so that we can find what each migration was in the future
|
I'll wait to rebase this until after #1556 is merged. |
williamjallen
force-pushed
the
php-style-rules
branch
from
db0a8d7
to
0a3ee43
Compare
|
@josephsnyder Resolving all of the git conflicts was difficult and resulted in invalid PHP in several places, so I simply recreated all of the changes. I think everything should be the same as before (except that it's rebased now), but I think it's worth having an extra pair of eyes take a look before merging this. |
josephsnyder
approved these changes
Aug 18, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP-CS-Fixer provides a ruleset for most major and minor PHP versions which flags deprecated functions and ensures that our code style keeps up with modern PHP style guidelines. This PR is part of a series of improvements in which I intend to gradually turn on more style check rules as we modernize the codebase.