Add foreign key constraints for all buildids #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
force-pushed
the
build-foreign-keys
branch
from
c91e5bf
to
803cb28
Compare
williamjallen
force-pushed
the
build-foreign-keys
branch
2 times, most recently
from
68d1628
to
e4bfb7e
Compare
williamjallen
force-pushed
the
build-foreign-keys
branch
from
e4bfb7e
to
0022007
Compare
josephsnyder
approved these changes
Aug 30, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
zackgalbreath
added a commit
that referenced
this pull request
Mar 1, 2024
Follow-up to #1657 Remove DELETE statements that are now handled by cascading foreign keys instead.
zackgalbreath
added a commit
that referenced
this pull request
Mar 1, 2024
Follow-up to #1657 Remove DELETE statements that are now handled by cascading foreign keys instead.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 1, 2024
Follow-up to #1657 Remove DELETE statements that are now handled by cascading foreign keys instead.
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon the work in #1655, and adds foreign key constraints to all buildid columns. Like #1655, a handful of changes to our test suite were required to ensure that the constraints were fully met during the testing process.
This is related to issue #1442.