Add test for controller names

[williamjallen]

CDash has a controller naming and designation convention, as discussed in #1587. Since then, I have forgotten to mark several new controllers as "final". I have added a test to enforce these rules automatically, rather than relying upon human reviewers to catch it.

As seen in the diff for this PR, this test is quite effective. It caught the fact that the controllers in the Auth directory were not marked with the "final" keyword.

[josephsnyder]

Per our F2F conversation:

There seems to be an issue with the second and third tests as changing the name of a valid class returns the following error:

test 10
    Start 10: /Unit/app/ControllerNameTest

10: Test command: /usr/local/bin/php "/cdash/vendor/bin/phpunit" "-c" "/cdash/phpunit.xml" "/cdash/tests//Unit/app/ControllerNameTest.php"
10: Test timeout computed to be: 1500
10: PHPUnit 9.6.4 by Sebastian Bergmann and contributors.
10: 
10: EPHP Fatal error:  Cannot declare class App\Http\Controllers\Auth\AVerificationController, because the name is already in use in /cdash/app/Http/Controllers/Auth/VerificationController.php on line 8
10: 
10: In VerificationController.php line 8:
10:                                                                                                               
10:   Cannot declare class App\Http\Controllers\Auth\AVerificationController, because the name is already in use  
10:                                                                                                               
10: 
10: 
10: In VerificationController.php line 8:
10:                                                                                                               
10:   Cannot declare class App\Http\Controllers\Auth\AVerificationController, because the name is already in use  
10:                                                                                                               
10: 
1/1 Test #10: /Unit/app/ControllerNameTest .....***Failed    0.28 sec

[williamjallen]

@josephsnyder This one is a tricky one to fix. The error you noted is caused by the autoloader expecting the file name to match the class name. I attempted to add a basic error message to hopefully point developers in the right direction in the rare case where this happens. I also deleted the test for this, since it's already being enforced by the autoloader anyway.