Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display build start time on viewConfigure.php and viewTest.php #1672

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

williamjallen
Copy link
Collaborator

The build start time has been added to the info table at the top of viewConfigure.php and viewTest.php.

I will add Cypress tests for the angular-based pages once I get Cypress set up.

Copy link

@bartlettroscoe bartlettroscoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@williamjallen, can we see what this looks like? Does the CDash build PR testing build a site that we can see? Is there a 'next' branch with that is used to display a CDash site?

@@ -15,7 +15,7 @@
</tr>
<tr>
<td align="left">
<b>Build Time: </b>
<b>Build Start Time: </b>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@williamjallen
Copy link
Collaborator Author

@williamjallen, can we see what this looks like? Does the CDash build PR testing build a site that we can see? Is there a 'next' branch with that is used to display a CDash site?

We don't currently have a way to build a site on every CI run. Doing so would be quite impractical. That said, we do build a docker image for every commit with a successful CI pipeline when we push to master. That's where the cdash:latest docker image comes from.

The best way to test out changes is to either install CDash or use a docker container locally and then switch to the relevant branch.

Here are screenshots from the CDash instance created by the test suite:

build/<id>/configure (previously viewConfigure.php):
image

viewBuildError.php:
image

viewTest.php:
image

It's worth noting that the UI is rather inconsistent between these three pages. I think it would be productive to do a major UI overhaul and standardize the UI a bit more, but we need to find an appropriate funding source for that work. In the meantime, I have just been adding UI improvements here and there (such as the styled table on viewTest.php) as I work my way through other refactoring efforts.

@bartlettroscoe
Copy link

@williamjallen, do those screen shots include the changes from the PR:

as well? It looks like it does.

@williamjallen
Copy link
Collaborator Author

@williamjallen, do those screen shots include the changes from the PR:

as well? It looks like it does.

Yes, the screenshots in the comment above are for the changes I made in this PR. There is one screenshot per page I changed.

@josephsnyder josephsnyder added this pull request to the merge queue Aug 31, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 31, 2023
@josephsnyder josephsnyder added this pull request to the merge queue Aug 31, 2023
Merged via the queue into Kitware:master with commit e6dfdd2 Aug 31, 2023
2 checks passed
@williamjallen williamjallen deleted the build-start-time branch August 31, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants