Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate user.php frontend from AngularJS to Vue #1706

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

williamjallen
Copy link
Collaborator

This PR continues our ongoing effort to phase out AngularJS in favor of Vue as our client-side rendering engine.

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be an issue with the "All Projects (Submit Only)" handling for authentication tokens.

I haven't dug into why, but when I create a token with the above scope, it reports an error to the console and doesn't update the page with the token information.

image

Refreshing the page though, does show that the token was created and can be revoked:

image

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! Thanks for the quick turn around.

@josephsnyder josephsnyder added this pull request to the merge queue Sep 13, 2023
Merged via the queue into Kitware:master with commit a7203f2 Sep 13, 2023
2 checks passed
@williamjallen williamjallen deleted the user-vue branch September 13, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants