Use Eloquent-based SubProject model whenever possible #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephsnyder
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
Per our F2F chat, changing the SLOW_PAGE_TIME locally let the subproject test passed successfully. I'm happy with the changes that I can see and manual usage of the page has no issues
Let's see if the CI has an issue with that test when it's in the merge queue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1695 created an Eloquent-based
SubProjectmodel, but did not attempt to change existing usages of the legacy model. This is a small follow-up PR which expands the usage of the project-subproject relationship to gain access to subprojects through the eloquent-based project model. Amongst other things, this change should make a few pages slightly faster by reducing the number of database queries executed when iterating over subprojects. This PR also unifies the logic for determining which subprojects were active on a given date. It is probable that the prior inconsistent logic caused unexpected behavior in rare cases.I intend to work on subproject <-> build relationships in a future PR.