Drop support for migration from CDash 2.x #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
force-pushed
the
cdash-2-migration
branch
from
83b47ba
to
393cefe
Compare
williamjallen
force-pushed
the
cdash-2-migration
branch
from
393cefe
to
b389b8a
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 23, 2024
#1801 removed most of the CDash 2.x migration logic, and rendered the upgrade button useless on `upgrade.php`. This PR eliminates the upgrade button, and associated logic. Since the button was the last place using the contents of the `version` database table, I created a migration to delete it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDash 3.2 will be the last version of CDash to support migration from CDash 2.x. CDash administrators who wish to upgrade their system from CDash 2.x should first upgrade to CDash 3.2, and then upgrade to the latest version of CDash.
With the imminent release of CDash 3.2 looming, I took some time to begin the process of removing CDash 2.x migration support in preparation for the CDash 3.3. release. This PR eliminates the migration files, logic, and tests for 2.x migrations, but retains the schema files and a handful of more complicated portions of the migration logic which I intend to remove in future PRs.