Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete duplicate version.php configuration file #1873

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

williamjallen
Copy link
Collaborator

The laravel configuration file in .../config/cdash.php contains version information which duplicates the information in the legacy version.php. This PR eliminates the legacy configuration file, and migrates all of the version-checking code to Laravel's configuration system.

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josephsnyder josephsnyder added this pull request to the merge queue Dec 11, 2023
Merged via the queue into Kitware:master with commit b0ad416 Dec 11, 2023
2 checks passed
@williamjallen williamjallen deleted the unused-version-php branch December 11, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants