Add a Build Notes e2e test

app/cdash/tests/js/e2e_tests/CMakeLists.txt

@@ -37,3 +37,4 @@ add_protractor_test(subprojectGroupOrder)
 add_cypress_e2e_test(calendar)
 add_cypress_e2e_test(colorblind)
 add_cypress_e2e_test(daterange)
+add_cypress_e2e_test(build-notes)

app/cdash/tests/selenium/CMakeLists.txt

@@ -24,8 +24,5 @@ endif()
 add_selenium_test(finduserproject)
 add_selenium_test(findusers)
 
-## Not used with the new GUI
-# add_selenium_test(buildnote)
-
 add_selenium_test(editsite)
 add_selenium_test(emailsubscription)

phpstan-baseline.neon

@@ -20674,36 +20674,6 @@ parameters:
  count: 1
  path: app/cdash/tests/sameImage.php
 
- -
- message: "#^Call to an undefined method Example\\:\\:click\\(\\)\\.$#"
- count: 1
- path: app/cdash/tests/selenium/test_buildnote.php
-
- -
- message: "#^Call to an undefined method Example\\:\\:mouseOver\\(\\)\\.$#"
- count: 1
- path: app/cdash/tests/selenium/test_buildnote.php
-
- -
- message: "#^Call to an undefined method Example\\:\\:open\\(\\)\\.$#"
- count: 1
- path: app/cdash/tests/selenium/test_buildnote.php
-
- -
- message: "#^Call to an undefined method Example\\:\\:waitForPageToLoad\\(\\)\\.$#"
- count: 1
- path: app/cdash/tests/selenium/test_buildnote.php
-
- -
- message: "#^Method Example\\:\\:setUp\\(\\) has no return type specified\\.$#"
- count: 1
- path: app/cdash/tests/selenium/test_buildnote.php
-
- -
- message: "#^Method Example\\:\\:testBuildNote\\(\\) has no return type specified\\.$#"
- count: 1
- path: app/cdash/tests/selenium/test_buildnote.php
-
  -
  message: "#^Call to an undefined method Example\\:\\:click\\(\\)\\.$#"
  count: 10

tests/CMakeLists.txt

@@ -93,7 +93,6 @@ set_tests_properties(eslint PROPERTIES
 )
 
 add_vue_test(Spec/build-configure)
-add_vue_test(Spec/build-notes)
 add_vue_test(Spec/build-summary)
 add_vue_test(Spec/edit-project)
 add_vue_test(Spec/manage-measurements)

tests/cypress/e2e/build-notes.cy.js

@@ -0,0 +1,36 @@
+describe('build notes', () => {
+ it('can be reached from the index page', () => {
+ cy.visit('index.php?project=EmailProjectExample');
+ cy.get('tbody').find('tr').first().find('td').eq(1).find('a[name="notesLink"]').as('notes_link');
+ cy.get('@notes_link').find('img').should('have.attr', 'src', 'img/document.png');
+ cy.get('@notes_link').click();
+ cy.url().should('match', /builds\/[0-9]+\/notes/);
+ });
+
+ it('displays contents of note', () => {
+ cy.visit('index.php?project=EmailProjectExample');
+ cy.get('tbody').find('a[name="notesLink"]').click();
+
+ // verify content of note
+ cy.get('#note0').should('contain', '/cdash/_build/app/cdash/tests/ctest/ctestdriver-svnUpdates.ctest');
+ // some expected code from the attached note
+ cy.get('#notetext0')
+ .should('contain', 'cmake_minimum_required')
+ .and('contain', 'submit.php?project=EmailProjectExample');
+
+ // toggle the note
+ cy.get('#note0').find('i').as('toggle_button');
+ cy.get('@toggle_button').should('have.class', 'glyphicon-chevron-down');
+ cy.get('@toggle_button').click();
+
+ // TODO: (sbelsk) perhaps the choice of icons for the
+ // collapsed and open modes should be revisited...
+ cy.get('@toggle_button').should('have.class', 'glyphicon-chevron-right');
+ cy.get('#notetext0').should('not.be.visible');
+ cy.get('@toggle_button').click();
+
+ // assert page is back to original state
+ cy.get('@toggle_button').should('have.class', 'glyphicon-chevron-down');
+ cy.get('#notetext0').should('be.visible');
+ });
+});