Switch CI provider to GitHub Actions #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
force-pushed
the
gh-actions
branch
from
ae22aab
to
8a658ea
Compare
|
Since I'm working from a fork, the new CI will not show up here until this PR is merged. To demonstrate that these changes work as expected, I have:
In all of the workflow runs linked above, the runs failed at the end due to missing Docker Hub credentials. Adding the credentials to this repository should resolve the issue. |
|
Note: #2088 should be merged before this. |
williamjallen
force-pushed
the
gh-actions
branch
from
3ed105f
to
aaa4d51
Compare
williamjallen
force-pushed
the
gh-actions
branch
from
aaa4d51
to
dca2694
Compare
zackgalbreath
approved these changes
Mar 28, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
#2095 switched our CI provider from CircleCI to GitHub Actions, but broke our integration with CDash. The checkout action provided by GitHub runs workflows triggered by the `pull_request` event against a [merge commit](actions/checkout#426) instead of the PR's head ref. This causes issues with the CDash integration since the git hash CDash receives does not match the most recent hash on the pull request. I was not able to resolve the callback issue, but the changes in this PR improve the CDash build name being submitted, and assign runs to appropriate build groups. I plan to take another look at this issue at a future point to restore our CDash callback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of support for a second base image in #2088, we no longer have enough CircleCI credits to test both images properly. GitHub Actions also provides more substantial runners and better caching, which may reduce the overall running time.
This PR supersedes #2078.